Commit Graph
3275 Commits
Author SHA1 Message Date
Christian Grothoff 7078145599 proposed fix for #6116 2020-03-10 21:11:06 +01:00
Christian Grothoff eeb9c46884 declare victory on #6090, bump header version 2020-03-07 17:21:17 +01:00
Christian Grothoff 9b935deff6 documented to return zero on failure, not vice versa 2020-03-07 17:18:44 +01:00
Christian Grothoff 9ebe27e18d check for socket validity 2020-03-07 17:09:22 +01:00
Christian Grothoff 9f4422e0ca fix bad FTBFS 2020-03-07 17:05:42 +01:00
Christian Grothoff 63e395407f fix bad FTBFS 2020-03-07 17:05:04 +01:00
Christian Grothoff feed888b90 default is CORK is ON (at least on OS X) 2020-03-05 17:16:06 +01:00
Christian Grothoff 67de676736 try to fix OS X issue (#6090) 2020-03-05 16:49:16 +01:00
Christian Grothoff 844d571442 remove useless 'if', fix HTML output 2020-03-01 18:58:56 +01:00
Christian Grothoff 0c3fad0288 log more 2020-02-19 17:28:05 +01:00
Christian Grothoff eda21a5c2a clean up #define mess a bit 2020-02-14 15:40:18 +01:00
Christian Grothoff 902e3774f5 explain non-blocking is guaranteed (#6019) 2020-02-09 23:41:01 +01:00
Christian Grothoff fe6716d103 releasing 0.9.70 v0.9.70 2020-02-08 21:58:26 +01:00
Christian Grothoff ea5c330c44 bump revision 2020-02-08 16:49:46 +01:00
Christian Grothoff 78d0fb7b29 fix #6068 (enable 100 continue handling for PATCH requests) 2020-02-08 16:48:42 +01:00
Christian Grothoff 44c32e4ca7 fix #6078 2020-02-07 14:26:22 +01:00
Christian Grothoff 6da31a1c9f fix #6036 2020-02-07 14:23:50 +01:00
Christian Grothoff 94e8d665a1 fix #6025 2020-02-07 14:18:49 +01:00
Christian Grothoff a2103adbc4 add clarifying assert that digest must not be NULL 2020-02-05 19:26:54 +01:00
Christian Grothoff 2d4289dca7 add test for PATCH method 2020-02-04 20:14:02 +01:00
Christian Grothoff b8a0f69866 Hi,
I fixed an issue with the Gitlab CI.

Please apply the attached patch.

Regards, Tim
2020-01-27 20:37:32 +01:00
Christian Grothoff e0aacd946e add connection: close to 401 replies (experimental, under review) 2020-01-08 17:54:09 +01:00
Christian Grothoff f34781c87e add post processor logic fix 2019-12-26 14:44:18 +01:00
Christian Grothoff 55f715e15e first experimental rewrite of URL postprocessor, still fails, not production ready 2019-12-25 22:58:20 +01:00
Christian Grothoff 0f4460e545 more logging in testcase 2019-12-25 22:58:03 +01:00
Christian Grothoff f5d59eb3a7 Given post body "a&b=1", how should MHD interpret the data?
I'm at the end of a long investigation and it's come down to that question
for post_process_urlencoded() in MHD.

MHD currently calls back with ("a&b", "1").  The app I'm working breaks
when it doesn't receive a callback for "b".  The http client in this case
(that did the urlencoding) is google-http-java-client 1.23.0.

The client behavior may be questionable, but MHD's behavior doesn't seem
right either.  Isn't there some principle, "clients should strive for
conformance, servers should strive for forgiveness".

I've attached a patch to MHD to add a failing test, but without a fix.

As for relevant standards, the W3C[1] is not detailed enough to cover it.
The WhatWG[2] is more specific and allows for empty values and even empty
keys.  I'd like to callout uriparser[3], another C library I've patched in
as a work-around.  Uriparser documents their handling of these cases well:

* NULL in the value member means there was no '=' in the item text as with
"?abc&def".
* An empty string in the value member means there was '=' in the item as
with "?abc=&def".

[1] https://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.1
[2] https://url.spec.whatwg.org/#urlencoded-parsing
[3] https://uriparser.github.io/doc/api/latest/#querystrings

commit aa0534af56d135e1b261d127af09c22015c1ff87
Author: Ethan Tuttle <ethan@ethantuttle.com>
Date:   Tue Dec 24 03:50:59 2019 -0800

    urlencoding post-processor: add failing tests for keys without values
2019-12-24 15:33:05 +01:00
Christian Grothoff 878c8c7e01 Merge branch 'master' of git+ssh://gnunet.org/libmicrohttpd 2019-12-23 10:15:02 +01:00
ng0 bc0f8b829f ignore temp files 2019-12-20 10:59:53 +00:00
Christian Grothoff 3a661f8675 releasing 0.9.69 v0.9.69 2019-12-15 14:17:15 +01:00
Christian Grothoff 6f3a998f22 fix #5977 2019-12-15 14:12:56 +01:00
Christian Grothoff 4cd47bcc3c better use memcpy 2019-12-12 14:29:59 +01:00
Christian Grothoff 8869259c7f if suspended on POST before 100 CONTINUE, give application a second chance to queue non-100 CONTINUE response 2019-11-29 23:23:05 +01:00
ng0 84216009dd Add build-common submodule. 2019-11-02 16:11:25 +00:00
Christian Grothoff 7389c34528 tighten formatting rules 2019-10-31 13:06:08 +01:00
ng0 e0a0762845 .3: Files markup. 2019-10-28 00:13:53 +00:00
ng0 05e64565fb libmicrohttpd.3: Use mdocml, adjust to some standards, fix some markup. 2019-10-28 00:06:09 +00:00
Christian Grothoff fccdf42226 fix #5944 as suggested by reporter 2019-10-26 19:40:51 +02:00
Christian Grothoff 86186edbf3 version bump v0.9.68 2019-10-26 19:31:15 +02:00
Christian Grothoff 0237123940 bump version 2019-10-26 18:56:03 +02:00
Christian Grothoff 1fe2d0d352 fix regression: uncork when HTTPS is used in conjunction with empty response body 2019-10-26 18:53:58 +02:00
Christian Grothoff 5e5dbf980d add tests for empty reply in HTTPS 2019-10-26 18:52:53 +02:00
Christian Grothoff b8516d23ba add more bools 2019-10-25 14:46:01 +02:00
Christian Grothoff 185f740e06 allow clients to override sanity check for content-length header 2019-10-25 14:43:36 +02:00
Christian Grothoff 3e2ba2b1ce use booleans more nicely 2019-10-24 17:54:14 +02:00
Christian Grothoff 13d3805dc6 use bit-test as we do in MHD_get_connection_values() 2019-10-24 17:48:14 +02:00
Christian Grothoff 82e6ba21d2 add minimal example for empty body 2019-10-24 12:46:27 +02:00
Christian Grothoff 4ce0a69094 CI fix from Tim 2019-10-18 15:01:19 +02:00
Christian Grothoff 093c83c227 fix missing ret, thanks, Markus 2019-10-17 23:10:34 +02:00
Christian Grothoff dab960711f avoid log message on EOPNOTSUPP for UNIX domain sockets, as suggested by Markus 2019-10-17 20:56:19 +02:00
Christian Grothoff 35877189f6 cosmetics for Markus 2019-10-17 19:12:08 +02:00