mirrors/libmicrohttpd
2
0
Fork 0
mirror of https://git.gnunet.org/libmicrohttpd.git synced 2026-09-25 04:09:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

connection: reject or log requests with both chunked encoding and Content-Length

Browse Source
This commit is contained in:
Evgeny Grin (Karlson2k)
2022-11-06 15:01:18 +03:00
parent 377e2cbd52
commit 099b50e44a
1 changed files with 42 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/microhttpd/connection.c
+42
View File
@@ -102,6 +102,21 @@
#define REQUEST_UNSUPPORTED_TR_ENCODING ""
#endif
/**
* Response text used when the request has unsupported both headers:
* "Transfer-Enconding:" and "Content-Length:"
*/
#ifdef HAVE_MESSAGES
#define REQUEST_LENGTH_WITH_TR_ENCODING \
"<html>" \
"<head><title>Malformed request</title></head>" \
"<body>Wrong combination of the request headers: both Transfer-Encoding " \
"and Content-Length headers are used at the same time.</body>" \
"</html>"
#else
#define REQUEST_LENGTH_WITH_TR_ENCODING ""
#endif
/**
* Response text used when the request (http header) is
* malformed.
@@ -3996,6 +4011,33 @@ parse_connection_headers (struct MHD_Connection *connection)
REQUEST_UNSUPPORTED_TR_ENCODING);
return;
}
else if (MHD_NO !=
MHD_lookup_connection_value_n (connection,
MHD_HEADER_KIND,
MHD_HTTP_HEADER_CONTENT_LENGTH,
MHD_STATICSTR_LEN_ ( \
MHD_HTTP_HEADER_CONTENT_LENGTH),
NULL,
NULL))
{
/* TODO: add individual settings */
if (1 <= connection->daemon->strict_for_client)
{
transmit_error_response_static (connection,
MHD_HTTP_BAD_REQUEST,
REQUEST_LENGTH_WITH_TR_ENCODING);
return;
}
#ifdef HAVE_MESSAGES
else
{
MHD_DLOG (connection->daemon,
_ ("The 'Content-Length' request header is ignored "
"as chunked Transfer-Encoding is used "
"for this request.\n"));
}
#endif /* HAVE_MESSAGES */
}
connection->rq.have_chunked_upload = true;
connection->rq.remaining_upload_size = MHD_SIZE_UNKNOWN;
}