mirrors/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2026-09-25 04:09:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix value returned by H5Pget_fapl_ros3_block_caching() (#6602)

Browse Source 
When called on a FAPL without ROS3 VFD block caching parameters
set on it, the H5Pget_fapl_ros3_block_caching() function previously
returned the VFD's default page buffer size value instead of its
default I/O block cache size value.
This commit is contained in:
jhendersonHDF
2026-08-14 15:39:01 -05:00
committed by GitHub
parent 9dc6cd2f1f
commit f8f0379c7c
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/H5FDros3.c
+1 -1
View File
@@ -1150,7 +1150,7 @@ H5Pget_fapl_ros3_block_caching(hid_t fapl_id, size_t *block_size, size_t *block_
if (block_size)
*block_size = HDF5_ROS3_VFD_DEFAULT_BLOCK_SIZE;
if (block_cache_size)
*block_cache_size = ROS3_DEF_PAGE_BUF_SIZE;
*block_cache_size = HDF5_ROS3_VFD_DEFAULT_BLOCK_CACHE_SIZE;
if (lock_superblock)
*lock_superblock = true;
}
test/ros3.c
+10
View File
@@ -1188,6 +1188,16 @@ test_ros3_block_caching_apis(void)
if (H5Pset_fapl_ros3_token(fapl_id, s3_test_aws_session_token) < 0)
TEST_ERROR;
/* Test settings on FAPL without ROS3 VFD block caching set yet */
if (H5Pget_fapl_ros3_block_caching(fapl_id, &block_size, &block_cache_size, &lock_superblock) < 0)
TEST_ERROR;
if (block_size != HDF5_ROS3_VFD_DEFAULT_BLOCK_SIZE)
TEST_ERROR;
if (block_cache_size != HDF5_ROS3_VFD_DEFAULT_BLOCK_CACHE_SIZE)
TEST_ERROR;
if (!lock_superblock)
TEST_ERROR;
/* Set block size to 0 - should disable block caching */
if (H5Pset_fapl_ros3_block_caching(fapl_id, 0, HDF5_ROS3_VFD_DEFAULT_BLOCK_CACHE_SIZE, true) < 0)
TEST_ERROR;