mirrors/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2026-09-25 04:09:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

Unlink file free space section on failure to update data structures (#5815)

Browse Source 
When linking a file free space section into a free space manager's
internal data structures, the library previously wouldn't unlink
the free space section when it failed to update the free space
manager's internal data structures. This could eventually result
in a use-after-free issue due to the stale reference kept around.
This commit is contained in:
jhendersonHDF
2025-09-16 13:14:21 -05:00
committed by GitHub
parent 957a509151
commit ea4b483d98
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/H5FSsection.c
+10 -2
View File
@@ -1057,8 +1057,9 @@ done:
static herr_t
H5FS__sect_link(H5FS_t *fspace, H5FS_section_info_t *sect, unsigned flags)
{
const H5FS_section_class_t *cls; /* Class of section */
herr_t ret_value = SUCCEED; /* Return value */
const H5FS_section_class_t *cls; /* Class of section */
bool linked_sect = false; /* Was the section linked in? */
herr_t ret_value = SUCCEED; /* Return value */
FUNC_ENTER_PACKAGE
@@ -1073,6 +1074,7 @@ H5FS__sect_link(H5FS_t *fspace, H5FS_section_info_t *sect, unsigned flags)
/* Add section to size tracked data structures */
if (H5FS__sect_link_size(fspace->sinfo, cls, sect) < 0)
HGOTO_ERROR(H5E_FSPACE, H5E_CANTINSERT, FAIL, "can't add section to size tracking data structures");
linked_sect = true;
/* Update rest of free space manager data structures for section addition */
if (H5FS__sect_link_rest(fspace, cls, sect, flags) < 0)
@@ -1080,6 +1082,12 @@ H5FS__sect_link(H5FS_t *fspace, H5FS_section_info_t *sect, unsigned flags)
"can't add section to non-size tracking data structures");
done:
if (ret_value < 0) {
if (linked_sect && H5FS__sect_unlink_size(fspace->sinfo, cls, sect) < 0)
HDONE_ERROR(H5E_FSPACE, H5E_CANTFREE, FAIL,
"can't remove section from size tracking data structures");
}
FUNC_LEAVE_NOAPI(ret_value)
} /* H5FS__sect_link() */