mirrors/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2026-09-25 04:09:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

Restrict fscanf %s in h5import (#5887)

Browse Source 
A couple of places in the h5import.c code use fscanf with %s to read
strings into a fixed-size buffer without restricting the number
of characters, which could lead to a stack buffer overflow.

This fix restricts the number of characters that can be read to
the size of the buffer.
This commit is contained in:
Dana Robinson
2025-09-30 09:40:15 -05:00
committed by GitHub
parent 1f52fdccb8
commit d775fa0712
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/src/h5import/h5import.c
+2 -2
View File
@@ -586,7 +586,7 @@ readIntegerData(FILE *strm, struct Input *in)
switch (in->inputClass) {
case 0: /* TEXTIN */
for (i = 0; i < len; i++, in64++) {
if (fscanf(strm, "%s", buffer) < 1) {
if (fscanf(strm, "%255s", buffer) < 1) {
(void)fprintf(rawerrorstream, "%s", err1);
return (-1);
}
@@ -753,7 +753,7 @@ readUIntegerData(FILE *strm, struct Input *in)
switch (in->inputClass) {
case 6: /* TEXTUIN */
for (i = 0; i < len; i++, in64++) {
if (fscanf(strm, "%s", buffer) < 1) {
if (fscanf(strm, "%255s", buffer) < 1) {
(void)fprintf(rawerrorstream, "%s", err1);
return (-1);
}