Merge topic 'iwyu-memory'

71fbebd1dc IWYU: Fix handling of <memory> standard header

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Marc Chevrier <marc.chevrier@gmail.com>
Merge-request: !3536
This commit is contained in:
Brad King
2019-07-11 08:52:36 -04:00
committed by Kitware Robot
88 changed files with 104 additions and 69 deletions
+1 -1
View File
@@ -7,7 +7,7 @@
#include "cmsys/RegularExpression.hxx"
#include <algorithm>
#include <cstring>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <utility>
#include "cmCPackComponentGroup.h"
-1
View File
@@ -5,7 +5,6 @@
#include "cmsys/Encoding.hxx"
#include <iostream>
#include <map>
#include <memory> // IWYU pragma: keep
#include <sstream>
#include <stddef.h>
#include <string>
-1
View File
@@ -6,7 +6,6 @@
#include "cmsys/Process.h"
#include "cmsys/RegularExpression.hxx"
#include <iostream>
#include <memory> // IWYU pragma: keep
#include <stdlib.h>
#include <string.h>
@@ -29,11 +29,13 @@
#include <iostream>
#include <list>
#include <math.h>
#include <memory>
#include <sstream>
#include <stack>
#include <stdlib.h>
#include <unordered_map>
#include <utility>
#include <vector>
namespace cmsys {
class RegularExpression;
+2 -1
View File
@@ -5,6 +5,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <memory>
#include <set>
#include <stddef.h>
#include <string>
@@ -12,7 +13,7 @@
#include "cmCTestTestHandler.h"
#include "cmDuration.h"
#include "cmProcess.h" // IWYU pragma: keep (for unique_ptr)
#include "cmProcess.h"
class cmCTest;
class cmCTestMultiProcessHandler;
+1 -1
View File
@@ -11,7 +11,7 @@
#include <functional>
#include <iomanip>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <sstream>
#include <stdio.h>
+1 -1
View File
@@ -18,7 +18,7 @@
#include "cmXMLWriter.h"
#include <chrono>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
static const char* cmCTestUpdateHandlerUpdateStrings[] = {
+1 -1
View File
@@ -9,7 +9,7 @@
#include "cmLDConfigTool.h"
#include "cmStateTypes.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmBinUtilsMacOSMachOGetRuntimeDependenciesTool.h"
#include "cmStateTypes.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmBinUtilsWindowsPEGetRuntimeDependenciesTool.h"
#include "cmStateTypes.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
class cmRuntimeDependencyArchive;
+1 -1
View File
@@ -15,7 +15,7 @@
#include <ctype.h>
#include <iostream>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <stdlib.h>
+1 -1
View File
@@ -10,7 +10,7 @@
#include <chrono>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <string>
#include <time.h>
+1
View File
@@ -10,6 +10,7 @@
#include "cmTargetLinkLibraryType.h"
#include <map>
#include <memory>
#include <queue>
#include <set>
#include <string>
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmsys/FStream.hxx"
#include <string.h>
#include <memory> // IWYU pragma: keep
#include <memory>
static unsigned int const cmCryptoHashAlgoToId[] = {
/* clang-format needs this comment to break after the opening brace */
+1 -1
View File
@@ -5,7 +5,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <memory> // IWYU pragma: keep
#include <memory>
#include <stddef.h>
#include <string>
#include <vector>
+1 -1
View File
@@ -12,7 +12,7 @@
#include "cmStateTypes.h"
#include "cmSystemTools.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <stddef.h>
#include <utility>
+1 -1
View File
@@ -6,7 +6,7 @@
#include "cm_kwiml.h"
#include "cmsys/FStream.hxx"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stddef.h>
#include <utility>
+3
View File
@@ -4,10 +4,13 @@
#include "cm_static_string_view.hxx"
#include "cmsys/Process.h"
#include <algorithm>
#include <ctype.h> /* isspace */
#include <iostream>
#include <memory>
#include <stdio.h>
#include <vector>
#include "cmAlgorithms.h"
#include "cmArgumentParser.h"
@@ -3,7 +3,6 @@
#include "cmExportBuildAndroidMKGenerator.h"
#include <algorithm>
#include <memory> // IWYU pragma: keep
#include <sstream>
#include <utility>
+1 -1
View File
@@ -20,7 +20,7 @@
#include "cmsys/FStream.hxx"
#include <assert.h>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <string.h>
#include <utility>
@@ -4,7 +4,7 @@
#include "cmsys/FStream.hxx"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <utility>
#include "cmAlgorithms.h"
+1 -1
View File
@@ -13,7 +13,7 @@
#include "cmTarget.h"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <utility>
cmExportTryCompileFileGenerator::cmExportTryCompileFileGenerator(
+1 -1
View File
@@ -10,7 +10,7 @@
#include "cm_jsoncpp_writer.h"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <unordered_set>
#include <vector>
+1
View File
@@ -31,6 +31,7 @@
#include <algorithm>
#include <cassert>
#include <map>
#include <memory>
#include <set>
#include <string>
#include <unordered_map>
+1 -1
View File
@@ -13,7 +13,7 @@
#include <cmath>
#include <ctype.h>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <sstream>
#include <stdio.h>
+1 -1
View File
@@ -5,7 +5,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
/** \class cmFileTimes
+1 -1
View File
@@ -13,7 +13,7 @@
#include <deque>
#include <functional>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <string.h>
+1 -1
View File
@@ -2,7 +2,7 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmForEachCommand.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <stdlib.h>
+1 -1
View File
@@ -3,7 +3,7 @@
#include "cmGeneratorExpression.h"
#include "cmsys/RegularExpression.hxx"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <utility>
#include "assert.h"
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmListFileCache.h"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <string>
#include <utility>
@@ -3,7 +3,7 @@
#include "cmGeneratorExpressionEvaluationFile.h"
#include "cmsys/FStream.hxx"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <utility>
+1 -1
View File
@@ -6,7 +6,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1 -1
View File
@@ -33,7 +33,7 @@
#include <errno.h>
#include <iterator>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <sstream>
#include <stdlib.h>
+1 -1
View File
@@ -7,7 +7,7 @@
#include <assert.h>
#include <errno.h>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <queue>
#include <sstream>
#include <stdio.h>
+2
View File
@@ -22,9 +22,11 @@
#include "cmTarget.h"
#include <algorithm>
#include <memory>
#include <ostream>
#include <set>
#include <utility>
#include <vector>
cmGhsMultiTargetGenerator::cmGhsMultiTargetGenerator(cmGeneratorTarget* target)
: GeneratorTarget(target)
+1
View File
@@ -7,6 +7,7 @@
#include <iosfwd>
#include <map>
#include <memory>
#include <set>
#include <string>
#include <unordered_map>
+1 -1
View File
@@ -9,7 +9,7 @@
#include <algorithm>
#include <ctype.h>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
+1 -1
View File
@@ -7,7 +7,7 @@
#include <iosfwd>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <string>
#include <unordered_map>
@@ -4,6 +4,7 @@
#include <algorithm>
#include <functional>
#include <memory>
#include <sstream>
#include <utility>
+1 -1
View File
@@ -5,7 +5,7 @@
#include "cmsys/RegularExpression.hxx"
#include <assert.h>
#include <iomanip>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <string.h>
+1 -1
View File
@@ -4,7 +4,7 @@
#include <cstddef>
#include <iostream>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <utility>
+1 -1
View File
@@ -11,7 +11,7 @@
#include "cmSystemTools.h"
#include "cmake.h"
#include <memory> // IWYU pragma: keep
#include <memory>
static std::string cmIfCommandError(
std::vector<cmExpandedCommandArgument> const& args)
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmMakefile.h"
#include "cmSystemTools.h"
#include <memory> // IWYU pragma: keep
#include <memory>
cmInstallDirectoryGenerator::cmInstallDirectoryGenerator(
std::vector<std::string> const& dirs, const char* dest,
+1 -1
View File
@@ -6,7 +6,7 @@
#include "cmInstallType.h"
#include "cmSystemTools.h"
#include <memory> // IWYU pragma: keep
#include <memory>
class cmLocalGenerator;
+1
View File
@@ -2,6 +2,7 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmInstallScriptGenerator.h"
#include <memory>
#include <ostream>
#include <vector>
+1
View File
@@ -4,6 +4,7 @@
#include <assert.h>
#include <map>
#include <memory>
#include <set>
#include <sstream>
#include <utility>
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmGeneratorExpression.h"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1
View File
@@ -31,6 +31,7 @@
#include <functional>
#include <limits>
#include <map>
#include <memory>
#include <set>
#include <string>
#include <unordered_map>
+2
View File
@@ -7,12 +7,14 @@
#include <assert.h>
#include <functional>
#include <iterator>
#include <memory>
#include <set>
#include <sstream>
#include <stdexcept>
#include <stdio.h>
#include <stdlib.h> // required for atoi
#include <utility>
#include <vector>
#include "cmAlgorithms.h"
#include "cmGeneratorExpression.h"
+1 -1
View File
@@ -6,7 +6,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <iosfwd>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <stddef.h>
#include <string>
#include <utility>
+3 -1
View File
@@ -26,22 +26,24 @@
#include "cmTestGenerator.h"
#include "cmVersion.h"
#include "cmake.h"
#include "cmsys/RegularExpression.hxx"
#if defined(CMAKE_BUILD_WITH_CMAKE)
# define CM_LG_ENCODE_OBJECT_NAMES
# include "cmCryptoHash.h"
#endif
#include "cmsys/RegularExpression.hxx"
#include <algorithm>
#include <assert.h>
#include <initializer_list>
#include <iterator>
#include <memory>
#include <sstream>
#include <stdio.h>
#include <string.h>
#include <unordered_set>
#include <utility>
#include <vector>
#if defined(__HAIKU__)
# include <FindDirectory.h>
+1 -1
View File
@@ -5,7 +5,7 @@
#include <algorithm>
#include <assert.h>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <utility>
+1 -1
View File
@@ -5,7 +5,7 @@
#include "cmsys/FStream.hxx"
#include "cmsys/Terminal.h"
#include <algorithm>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <utility>
+1 -1
View File
@@ -6,7 +6,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include "cmGlobalVisualStudioGenerator.h"
+1 -1
View File
@@ -9,7 +9,7 @@
#include <cstring>
#include <ctype.h>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <stdlib.h>
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmsys/RegularExpression.hxx"
#include <deque>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <stack>
#include <stddef.h>
@@ -2,7 +2,7 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmMakefileExecutableTargetGenerator.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <sstream>
#include <string>
+1 -1
View File
@@ -2,7 +2,7 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmMakefileLibraryTargetGenerator.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <sstream>
#include <stddef.h>
+1 -1
View File
@@ -2,7 +2,7 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmMakefileTargetGenerator.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <utility>
+1
View File
@@ -7,6 +7,7 @@
#include <iosfwd>
#include <map>
#include <memory>
#include <set>
#include <string>
#include <vector>
@@ -2,6 +2,7 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmMakefileUtilityTargetGenerator.h"
#include <memory>
#include <ostream>
#include <string>
#include <utility>
+1 -1
View File
@@ -6,7 +6,7 @@
#include <assert.h>
#include <iterator>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <sstream>
#include <utility>
+1 -1
View File
@@ -8,7 +8,7 @@
#include <assert.h>
#include <iterator>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <ostream>
#include <utility>
+1 -1
View File
@@ -13,7 +13,7 @@
#include "cmOSXBundleGenerator.h"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <string>
#include <vector>
+1
View File
@@ -13,6 +13,7 @@
#include <assert.h>
#include <functional>
#include <sstream>
#include <vector>
/*
Directory ordering computation.
+1 -1
View File
@@ -5,7 +5,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmQtAutoGen.h"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <unordered_map>
#include <vector>
+1 -1
View File
@@ -8,7 +8,7 @@
#include "cmQtAutoGen.h"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <ostream>
#include <set>
#include <string>
+2
View File
@@ -14,6 +14,8 @@
#include "cmSystemTools.h"
#include "cmake.h"
#include <memory>
cmQtAutoGenerator::Logger::Logger()
{
// Initialize logger
+1 -1
View File
@@ -14,7 +14,7 @@
#include <atomic>
#include <cstddef>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <string>
#include <unordered_map>
+1 -1
View File
@@ -9,7 +9,7 @@
#include "cmsys/RegularExpression.hxx"
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <string>
#include <vector>
+1 -1
View File
@@ -10,7 +10,7 @@
#include "cmUVHandlePtr.h"
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1
View File
@@ -6,6 +6,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <map>
#include <memory>
#include <set>
#include <string>
#include <vector>
+1
View File
@@ -6,6 +6,7 @@
#include <algorithm>
#include <assert.h>
#include <iterator>
#include <vector>
#include "cmAlgorithms.h"
#include "cmProperty.h"
+1 -1
View File
@@ -8,7 +8,7 @@
#include <algorithm>
#include <ctype.h>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <stdlib.h>
+1 -1
View File
@@ -6,7 +6,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <iosfwd>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <string>
#include <utility>
+2
View File
@@ -2,8 +2,10 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmTestGenerator.h"
#include <memory>
#include <ostream>
#include <utility>
#include <vector>
#include "cmGeneratorExpression.h"
#include "cmGeneratorTarget.h"
+1 -1
View File
@@ -7,7 +7,7 @@
#include <array>
#include <iosfwd>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1 -1
View File
@@ -6,7 +6,7 @@
#include "cmConfigure.h" // IWYU pragma: keep
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <string>
#include <vector>
+1 -1
View File
@@ -19,7 +19,7 @@
#include "windows.h"
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
static void ConvertToWindowsSlash(std::string& s);
+1 -1
View File
@@ -9,7 +9,7 @@
#include "cmMessageType.h"
#include "cmSystemTools.h"
#include <memory> // IWYU pragma: keep
#include <memory>
cmWhileFunctionBlocker::cmWhileFunctionBlocker(cmMakefile* mf)
: Makefile(mf)
+1 -1
View File
@@ -7,7 +7,7 @@
#include "cmAlgorithms.h" // IWYU pragma: keep
#include <memory> // IWYU pragma: keep
#include <memory>
#include <stdint.h>
#include <string>
#include <utility>
+1 -1
View File
@@ -104,7 +104,7 @@
#include <cstring>
#include <initializer_list>
#include <iostream>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <stdlib.h>
+1 -1
View File
@@ -7,7 +7,7 @@
#include <functional>
#include <map>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <set>
#include <string>
#include <unordered_set>
+1 -1
View File
@@ -41,7 +41,7 @@
#include <array>
#include <iostream>
#include <iterator>
#include <memory> // IWYU pragma: keep
#include <memory>
#include <sstream>
#include <stdio.h>
#include <stdlib.h>
+1
View File
@@ -10,6 +10,7 @@
#include <algorithm>
#include <functional>
#include <iostream>
#include <memory>
#include <sstream>
#include <string>
#include <vector>
@@ -1,6 +1,8 @@
#include "cmConnection.h"
#include "cmServerConnection.h"
#include <iostream>
#include <memory>
#include <string>
#include <vector>
+9 -2
View File
@@ -42,10 +42,17 @@
{ symbol: [ "std::istringstream", private, "<sstream>", public ] },
{ symbol: [ "std::ostringstream", private, "<sstream>", public ] },
# HACK: iwyu suggests those two files each time vector[] is used.
# HACK: iwyu suggests <ext/alloc_traits.h> and <memory> each time vector[] is used.
# https://github.com/include-what-you-use/include-what-you-use/issues/166
{ include: [ "<ext/alloc_traits.h>", private, "<vector>", public ] },
{ include: [ "<memory>", public, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<cmComputeComponentGraph::TarjanEntry> >::value_type", private, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<cmFortranFile> >::value_type", private, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<cmGraphEdgeList> >::value_type", private, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<cmOrderDirectories::ConflictList> >::value_type", private, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<cmStateSnapshot> >::value_type", private, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<std::basic_string<char> > >::value_type", private, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<std::vector<std::basic_string<char>, std::allocator<std::basic_string<char> > > > >::value_type", private, "<vector>", public ] },
{ symbol: [ "std::allocator_traits<std::allocator<uv_stdio_container_s> >::value_type", private, "<vector>", public ] },
# TODO: enable this block and remove some <utility> includes?
#{ symbol: [ "std::pair", private, "<utility>", public ] },