-fix bogus assert, use proper libgcrypt type

This commit is contained in:
Christian Grothoff
2023-04-17 10:55:22 +02:00
parent 46357a33c1
commit eeb4166266
2 changed files with 6 additions and 9 deletions
+4 -4
View File
@@ -22,8 +22,6 @@
* @brief Wrapper for MD5 calculation performed by TLS library * @brief Wrapper for MD5 calculation performed by TLS library
* @author Karlson2k (Evgeny Grin) * @author Karlson2k (Evgeny Grin)
*/ */
#include <gnutls/crypto.h>
#include "md5_ext.h" #include "md5_ext.h"
#include "mhd_assert.h" #include "mhd_assert.h"
@@ -39,14 +37,16 @@ void
MHD_MD5_init_one_time (struct Md5CtxExt *ctx) MHD_MD5_init_one_time (struct Md5CtxExt *ctx)
{ {
ctx->handle = NULL; ctx->handle = NULL;
ctx->ext_error = gnutls_hash_init (&ctx->handle, GNUTLS_DIG_MD5); ctx->ext_error = gnutls_hash_init (&ctx->handle,
GNUTLS_DIG_MD5);
if ((0 != ctx->ext_error) && (NULL != ctx->handle)) if ((0 != ctx->ext_error) && (NULL != ctx->handle))
{ {
gnutls_free (ctx->handle); gnutls_free (ctx->handle);
ctx->handle = NULL; ctx->handle = NULL;
} }
else else
mhd_assert (NULL != ctx->handle); mhd_assert ( (NULL != ctx->handle) ||
(0 != ctx->ext_error) );
} }
+2 -5
View File
@@ -16,13 +16,11 @@
License along with GNU libmicrohttpd. License along with GNU libmicrohttpd.
If not, see <http://www.gnu.org/licenses/>. If not, see <http://www.gnu.org/licenses/>.
*/ */
/** /**
* @file microhttpd/md5_ext.h * @file microhttpd/md5_ext.h
* @brief Wrapper declarations for MD5 calculation performed by TLS library * @brief Wrapper declarations for MD5 calculation performed by TLS library
* @author Karlson2k (Evgeny Grin) * @author Karlson2k (Evgeny Grin)
*/ */
#ifndef MHD_MD5_EXT_H #ifndef MHD_MD5_EXT_H
#define MHD_MD5_EXT_H 1 #define MHD_MD5_EXT_H 1
@@ -31,6 +29,7 @@
#ifdef HAVE_STDDEF_H #ifdef HAVE_STDDEF_H
#include <stddef.h> /* for size_t */ #include <stddef.h> /* for size_t */
#endif /* HAVE_STDDEF_H */ #endif /* HAVE_STDDEF_H */
#include <gnutls/crypto.h>
/** /**
* Size of MD5 resulting digest in bytes * Size of MD5 resulting digest in bytes
@@ -38,8 +37,6 @@
*/ */
#define MD5_DIGEST_SIZE (16) #define MD5_DIGEST_SIZE (16)
/* Actual declaration is in GnuTLS lib header */
struct hash_hd_st;
/** /**
* Indicates that struct Md5CtxExt has 'ext_error' * Indicates that struct Md5CtxExt has 'ext_error'
@@ -51,7 +48,7 @@ struct hash_hd_st;
*/ */
struct Md5CtxExt struct Md5CtxExt
{ {
struct hash_hd_st *handle; /**< Hash calculation handle */ gnutls_hash_hd_t handle; /**< Hash calculation handle */
int ext_error; /**< Non-zero if external error occurs during init or hashing */ int ext_error; /**< Non-zero if external error occurs during init or hashing */
}; };