From b79c6bca0d047d717378290e675fa9f45d4694e6 Mon Sep 17 00:00:00 2001 From: "Evgeny Grin (Karlson2k)" Date: Mon, 18 Apr 2016 21:25:56 +0000 Subject: [PATCH] Added more comments about data races. --- src/microhttpd/daemon.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/microhttpd/daemon.c b/src/microhttpd/daemon.c index 5af6bd60..2173378d 100644 --- a/src/microhttpd/daemon.c +++ b/src/microhttpd/daemon.c @@ -1824,6 +1824,14 @@ resume_suspended_connections (struct MHD_Daemon *daemon) if (MHD_NO != daemon->resuming) next = daemon->suspended_connections_head; + /* Clear the flag *only* if connections will be resumed otherwise + it may accidentally clear flag that was set at the same time in + other thread (just after 'if (MHD_NO != daemon->resuming)' in + this thread). + Clear flag *before* resuming connections otherwise new connection can + be set to "resuming" in other thread, but missed resuming in this + function at this time so clearing flag at end will clear it without + actually resuming of new connection. */ if (NULL != next) daemon->resuming = MHD_NO; while (NULL != (pos = next))