From f9d99e38923eed71a501aefe97b63006f64f42c9 Mon Sep 17 00:00:00 2001 From: Matthew Woehlke Date: Mon, 27 Jul 2026 11:53:05 -0400 Subject: [PATCH] Tests: Fix symbolic component tests The tests added in commit d92b6c3e20 (CPS: Add Symbolic Components, 2025-09-01, v4.2.0-rc1~48^2~1) had an inverted conditional, such that they passed if the output did NOT match what was expected. The expected expressions were also improperly escaped, which "canceled" this error, allowing the tests to erroneously pass. Fix both of these errors. --- Tests/RunCMake/export/SymbolicComponent-check.cmake | 4 ++-- .../install/TARGETS-SymbolicComponent-all-check.cmake | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Tests/RunCMake/export/SymbolicComponent-check.cmake b/Tests/RunCMake/export/SymbolicComponent-check.cmake index 43d96fc710..617a648e01 100644 --- a/Tests/RunCMake/export/SymbolicComponent-check.cmake +++ b/Tests/RunCMake/export/SymbolicComponent-check.cmake @@ -1,4 +1,4 @@ file(READ "${RunCMake_TEST_BINARY_DIR}/foo.cmake" foo) -if("${foo}" MATCHES "add_library\(foo INTERFACE SYMBOLIC IMPORTED\)") - string(APPEND RunCMake_TEST_FAILED "Symbolic Component Foo was not exported\n") +if(NOT "${foo}" MATCHES "add_library\\(foo INTERFACE SYMBOLIC IMPORTED\\)") + string(APPEND RunCMake_TEST_FAILED "Interface library 'foo' Component Foo was not exported\n") endif() diff --git a/Tests/RunCMake/install/TARGETS-SymbolicComponent-all-check.cmake b/Tests/RunCMake/install/TARGETS-SymbolicComponent-all-check.cmake index bf0cb0e54a..d01d212fc2 100644 --- a/Tests/RunCMake/install/TARGETS-SymbolicComponent-all-check.cmake +++ b/Tests/RunCMake/install/TARGETS-SymbolicComponent-all-check.cmake @@ -1,5 +1,5 @@ file(READ "${RunCMake_TEST_BINARY_DIR}/root-all/foo.cmake" foo) -if("${foo}" MATCHES "add_library\(foo INTERFACE SYMBOLIC IMPORTED\)") +if(NOT "${foo}" MATCHES "add_library\\(foo INTERFACE SYMBOLIC IMPORTED\\)") string(APPEND RunCMake_TEST_FAILED "Symbolic Component Foo was not exported\n") endif()