From baa74ed677a247a9b05268aaa524909a09c0a9cf Mon Sep 17 00:00:00 2001 From: Vito Gamberini Date: Mon, 14 Jul 2025 10:20:42 -0400 Subject: [PATCH] clang-tidy: Use cleaner path to export-fixes file with Ninja The clang-tidy "export-fixes" flag was using unconverted Ninja paths due to a flipped boolean check from commit 993dde925f (TargetGenerator: Factor out generation of code check rules, 2023-05-12, v3.27.0-rc1~84^2~2). --- Source/cmCommonTargetGenerator.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/cmCommonTargetGenerator.cxx b/Source/cmCommonTargetGenerator.cxx index 5a37f0bf61..867f1af298 100644 --- a/Source/cmCommonTargetGenerator.cxx +++ b/Source/cmCommonTargetGenerator.cxx @@ -463,7 +463,7 @@ std::string cmCommonTargetGenerator::GenerateCodeCheckRules( this->GlobalCommonGenerator->AddClangTidyExportFixesFile(fixesFile); cmSystemTools::MakeDirectory( cmSystemTools::GetFilenamePath(fixesFile)); - if (!pathConverter) { + if (pathConverter) { fixesFile = pathConverter(fixesFile); } exportFixes = cmStrCat(";--export-fixes=", fixesFile);