From a585e410c0329e46175c9aa85fcaaeca667b8ff8 Mon Sep 17 00:00:00 2001 From: Brad King Date: Mon, 8 Apr 2024 18:59:02 -0400 Subject: [PATCH] cmGeneratorExpressionDAGChecker: Inline initialization in constructor --- Source/cmGeneratorExpressionDAGChecker.cxx | 23 +++++++++------------- Source/cmGeneratorExpressionDAGChecker.h | 1 - 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/Source/cmGeneratorExpressionDAGChecker.cxx b/Source/cmGeneratorExpressionDAGChecker.cxx index a0566f5dca..8cd4840a17 100644 --- a/Source/cmGeneratorExpressionDAGChecker.cxx +++ b/Source/cmGeneratorExpressionDAGChecker.cxx @@ -17,6 +17,15 @@ #include "cmStringAlgorithms.h" #include "cmake.h" +cmGeneratorExpressionDAGChecker::cmGeneratorExpressionDAGChecker( + cmGeneratorTarget const* target, std::string property, + const GeneratorExpressionContent* content, + cmGeneratorExpressionDAGChecker* parent) + : cmGeneratorExpressionDAGChecker(cmListFileBacktrace(), target, + std::move(property), content, parent) +{ +} + cmGeneratorExpressionDAGChecker::cmGeneratorExpressionDAGChecker( cmListFileBacktrace backtrace, cmGeneratorTarget const* target, std::string property, const GeneratorExpressionContent* content, @@ -28,20 +37,6 @@ cmGeneratorExpressionDAGChecker::cmGeneratorExpressionDAGChecker( , Backtrace(std::move(backtrace)) , TransitivePropertiesOnly(false) , CMP0131(false) -{ - this->Initialize(); -} - -cmGeneratorExpressionDAGChecker::cmGeneratorExpressionDAGChecker( - cmGeneratorTarget const* target, std::string property, - const GeneratorExpressionContent* content, - cmGeneratorExpressionDAGChecker* parent) - : cmGeneratorExpressionDAGChecker(cmListFileBacktrace(), target, - std::move(property), content, parent) -{ -} - -void cmGeneratorExpressionDAGChecker::Initialize() { const auto* top = this->Top(); this->CheckResult = this->CheckGraph(); diff --git a/Source/cmGeneratorExpressionDAGChecker.h b/Source/cmGeneratorExpressionDAGChecker.h index 782d6c8b7d..5f333fc28c 100644 --- a/Source/cmGeneratorExpressionDAGChecker.h +++ b/Source/cmGeneratorExpressionDAGChecker.h @@ -99,7 +99,6 @@ struct cmGeneratorExpressionDAGChecker private: Result CheckGraph() const; - void Initialize(); const cmGeneratorExpressionDAGChecker* const Parent; cmGeneratorTarget const* Target;