mirrors/cmake
2
0
Fork 0
mirror of https://gitlab.kitware.com/cmake/cmake.git synced 2026-09-25 04:09:36 +03:00
Code Activity

cmSystemTools: Fix clang tidy warning else after return

Browse Source 
warning: readability-else-after-return.
Also invert the if/else logic to avoid double negatives.
This commit is contained in:
John Franklin Rickard
2026-02-06 12:27:23 -05:00
committed by Brad King
parent d932b6fb8d
commit 70509802f5
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmSystemTools.cxx
+5 -7
View File
@@ -4402,11 +4402,10 @@ cm::string_view cmSystemTools::GetFilenameNameView(cm::string_view filename)
char separators = '/';
#endif
std::string::size_type slash_pos = filename.find_last_of(separators);
if (slash_pos != std::string::npos) {
return cm::string_view(filename).substr(slash_pos + 1);
} else {
return cm::string_view(filename);
if (slash_pos == std::string::npos) {
return filename;
}
return filename.substr(slash_pos + 1);
}
cm::string_view cmSystemTools::GetFilenameLastExtensionView(
@@ -4414,9 +4413,8 @@ cm::string_view cmSystemTools::GetFilenameLastExtensionView(
{
cm::string_view name = cmSystemTools::GetFilenameNameView(filename);
cm::string_view::size_type dot_pos = name.rfind('.');
if (dot_pos != std::string::npos) {
return name.substr(dot_pos);
} else {
if (dot_pos == std::string::npos) {
return cm::string_view();
}
return name.substr(dot_pos);
}