mirrors/cmake
2
0 Fork 0
mirror of https://gitlab.kitware.com/cmake/cmake.git synced 2026-10-07 04:02:23 +03:00
Code Activity

QCMakeCacheView: avoid temporary containers for iteration

Browse Source
This commit is contained in:
Daniel Pfeifer committed 2017-05-05 09:21:12 +02:00
1 parent a57b30bb60
commit 377d4df279
1 file changed
+10 -4
Download Patch File Download Diff File Expand all files Collapse all files
Source/QtDialog/QCMakeCacheView.cxx
+10 -4
View File
@@ -254,8 +254,11 @@ void QCMakeCacheModel::setProperties(const QCMakePropertyList& props)
QStandardItem* root = this->invisibleRootItem();
foreach (QString key, newPropsTree.keys()) {
QCMakePropertyList props2 = newPropsTree[key];
for (QMap<QString, QCMakePropertyList>::const_iterator iter =
newPropsTree.begin();
iter != newPropsTree.end(); ++iter) {
QString const& key = iter.key();
QCMakePropertyList const& props2 = iter.value();
QList<QStandardItem*> parentItems;
parentItems.append(
@@ -280,8 +283,11 @@ void QCMakeCacheModel::setProperties(const QCMakePropertyList& props)
}
}
foreach (QString key, newPropsTree2.keys()) {
QCMakePropertyList props2 = newPropsTree2[key];
for (QMap<QString, QCMakePropertyList>::const_iterator iter =
newPropsTree2.begin();
iter != newPropsTree2.end(); ++iter) {
QString const& key = iter.key();
QCMakePropertyList const& props2 = iter.value();
QStandardItem* parentItem =
new QStandardItem(key.isEmpty() ? tr("Ungrouped Entries") : key);