mirrors/cmake
2
0
Fork 0
mirror of https://gitlab.kitware.com/cmake/cmake.git synced 2026-09-25 04:09:36 +03:00
Code Activity

Add target properties to discover target's file set information

Browse Source 
Currently, target properties related to file sets are specific to file set
type (for example "SOURCE_SETS"). This raises some concerns:
1. For each new file set type, 6 new properties are created which need a lot
   off documentation update
2. there is no "generic" way to discover file sets information

The new target properties (FILE_SET_TYPES, FILE_SETS_<TYPE>,
and INTERFACE_FILE_SETS_<TYPE>), in conjunction with the file sets
properties, enable a complete generic file sets information discovery.
This commit is contained in:
Marc Chevrier
2026-06-30 16:03:32 +02:00
parent ab78260559
commit 08855d03c2
13 changed files with 198 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmTarget.cxx
+33
View File
@@ -41,6 +41,7 @@
#include "cmState.h"
#include "cmStateDirectory.h"
#include "cmStateSnapshot.h"
#include "cmStringAlgorithms.h"
#include "cmSystemTools.h"
#include "cmTargetPropertyComputer.h"
#include "cmValue.h"
@@ -2114,6 +2115,7 @@ bool IsSettableProperty(cmMakefile* context, cmTarget* target,
using ROC = ReadOnlyCondition;
static std::unordered_map<std::string, ReadOnlyProperty> const readOnlyProps{
{ "EXPORT_NAME", { ROC::Imported } },
{ "FILE_SET_TYPES", { ROC::All } },
{ "HEADER_SETS", { ROC::All } },
{ "IMPORTED_GLOBAL", { ROC::NonImported } },
{ "INTERFACE_HEADER_SETS", { ROC::All } },
@@ -2181,6 +2183,11 @@ void cmTarget::SetProperty(std::string const& prop, cmValue value)
}
}
if (cmHasPrefix(prop, "FILE_SETS_"_s) ||
cmHasPrefix(prop, "INTERFACE_FILE_SETS_"_s)) {
// these properties are always read-only
return;
}
for (auto& fileSetType : this->impl->FileSetTypes) {
if (fileSetType.second.WriteProperties(this, this->impl.get(), prop, value,
FileSetType::Action::Set)) {
@@ -2773,6 +2780,32 @@ cmValue cmTarget::GetProperty(std::string const& prop) const
}
// Check fileset properties.
if (prop == "FILE_SET_TYPES"_s) {
static std::string fsTypes;
cmList types;
for (auto const& fileSetType : this->impl->FileSetTypes) {
if (!fileSetType.second.SelfEntries.Entries.empty() ||
!fileSetType.second.InterfaceEntries.Entries.empty()) {
types.push_back(fileSetType.first);
}
}
std::sort(types.begin(), types.end());
fsTypes = types.to_string();
return cmValue{ fsTypes };
}
if (cmHasPrefix(prop, "FILE_SETS_"_s)) {
static std::string fileSets;
std::string type = prop.substr(10);
fileSets = cmList::to_string(this->GetFileSetsEntries(type));
return cmValue{ fileSets };
}
if (cmHasPrefix(prop, "INTERFACE_FILE_SETS_"_s)) {
static std::string fileSets;
std::string type = prop.substr(20);
fileSets = cmList::to_string(this->GetInterfaceFileSetsEntries(type));
return cmValue{ fileSets };
}
{
for (auto const& fileSetType : this->impl->FileSetTypes) {
auto value =