SHS/qad
4
1
Fork 0
Code Issues 5 Pull Requests Releases Wiki Activity

apply some code analyzer recommendations

Browse Source
This commit is contained in:
Пелипенко Иван
2024-11-20 20:02:09 +03:00
parent 1becca7519
commit 04b40d367c
9 changed files with 25 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/piqt_utils/piqt_connection_edit.cpp
View File

@@ -20,7 +20,7 @@ ConnectionEdit::ConnectionEdit(QWidget * parent): QDialog(parent) {
conn = 0;
PICodeInfo::EnumInfo * ei = PICODEINFO::enums().value("PIIODevice::DeviceMode");
if (ei) {
piForeachC(PICodeInfo::EnumeratorInfo & e, ei->members)
for (const auto & e: ei->members)
#if PIP_VERSION >= PIP_MAKE_VERSION(2, 39, 0)
ui->comboMode->addItem(PI2QString(e.name.toString() + " (" + PIString::fromNumber(e.value) + ")"),
QVariant::fromValue<int>(e.value));
@@ -31,7 +31,7 @@ ConnectionEdit::ConnectionEdit(QWidget * parent): QDialog(parent) {
ui->comboMode->setCurrentIndex(ui->comboMode->count() - 1);
ei = PICODEINFO::enums().value("PIIODevice::DeviceOption");
if (ei) {
piForeachC(PICodeInfo::EnumeratorInfo & e, ei->members) {
for (const auto & e: ei->members) {
QCheckBox * cb = new QCheckBox();
#if PIP_VERSION >= PIP_MAKE_VERSION(2, 39, 0)
cb->setText(PI2QString(e.name.toString() + " (" + PIString::fromNumber(e.value) + ")"));
@@ -44,7 +44,7 @@ ConnectionEdit::ConnectionEdit(QWidget * parent): QDialog(parent) {
}
ei = PICODEINFO::enums().value("PIPacketExtractor::SplitMode");
if (ei) {
piForeachC(PICodeInfo::EnumeratorInfo & e, ei->members)
for (const auto & e: ei->members)
#if PIP_VERSION >= PIP_MAKE_VERSION(2, 39, 0)
ui->comboSplit->addItem(PI2QString(e.name.toString() + " (" + PIString::fromNumber(e.value) + ")"),
QVariant::fromValue<int>(e.value));

2
libs/piqt_utils/piqt_connection_view.cpp
View File

@@ -85,7 +85,7 @@ void FilterItem::rename() {
QString ms;
PICodeInfo::EnumInfo * ei = PICODEINFO::enums().value("PIPacketExtractor::SplitMode", 0);
if (ei) {
piForeachC(PICodeInfo::EnumeratorInfo & i, ei->members)
for (const auto & i: ei->members)
if (i.value == mode()) {
#if PIP_VERSION >= PIP_MAKE_VERSION(2, 39, 0)
ms = PI2QString(i.name.toString());

6
libs/piqt_utils/piqt_iodevice_edit_dialog.cpp
View File

@@ -13,7 +13,7 @@ IODeviceEditDialog::IODeviceEditDialog(QWidget * parent): QDialog(parent) {
ui->setupUi(this);
PICodeInfo::EnumInfo * ei = PICODEINFO::enums().value("PIIODevice::DeviceMode");
if (ei) {
piForeachC(PICodeInfo::EnumeratorInfo & e, ei->members)
for (const auto & e: ei->members)
#if PIP_VERSION >= PIP_MAKE_VERSION(2, 39, 0)
ui->comboMode->addItem(PI2QString(e.name.toString() + " (" + PIString::fromNumber(e.value) + ")"),
QVariant::fromValue<int>(e.value));
@@ -24,7 +24,7 @@ IODeviceEditDialog::IODeviceEditDialog(QWidget * parent): QDialog(parent) {
ui->comboMode->setCurrentIndex(ui->comboMode->count() - 1);
ei = PICODEINFO::enums().value("PIIODevice::DeviceOption");
if (ei) {
piForeachC(PICodeInfo::EnumeratorInfo & e, ei->members) {
for (const auto & e: ei->members) {
QCheckBox * cb = new QCheckBox();
#if PIP_VERSION >= PIP_MAKE_VERSION(2, 39, 0)
cb->setText(PI2QString(e.name.toString() + " (" + PIString::fromNumber(e.value) + ")"));
@@ -36,7 +36,7 @@ IODeviceEditDialog::IODeviceEditDialog(QWidget * parent): QDialog(parent) {
}
}
PIStringList pl = PIIODevice::availablePrefixes();
piForeachC(PIString & p, pl) {
for (const auto & p: pl) {
ui->comboType->addItem(PI2QString(p));
}
}