get rid of piForeach

apply some code analyzer recommendations
ICU flag now check if libicu exists
prepare for more accurate growth of containers (limited PoT, then constantly increase size)

utils/system_daemon/daemon.cpp

@@ -78,7 +78,7 @@ void Daemon::Remote::termTimerTick() {
 void Daemon::Remote::startAction(Daemon::PacketType a, const PIString & dir, const PIStringList & fl) {
 	_fl = fl;
 	if (!dir.isEmpty())
-		piForeach(PIString & s, _fl)
+		for (auto & s: _fl)
 			s.prepend(dir);
 	// piCout << "send" << _fl;
 	action = a;
@@ -122,7 +122,7 @@ void Daemon::Remote::updateDirEntries() {
 	// piCout << dir_my;
 	if (!dir_my.isExists()) dir_my = PIDir::current();
 	my_filelist = dir_my.entries();
-	piForeach(PIFile::FileInfo & f, my_filelist)
+	for (auto & f: my_filelist)
 		f.path = f.name();
 }
 
@@ -325,7 +325,7 @@ Daemon::~Daemon() {
 	dtimer.stopAndWait();
 	requestCloseShell();
 	PIVector<Remote *> rl = remotes.values();
-	piForeach(Remote * r, rl) {
+	for (auto * r: rl) {
 		r->shellClose();
 		delete r;
 	}
@@ -554,7 +554,7 @@ void Daemon::timerEvent(int delim) {
 	screen->lock();
 	list_daemons->content.clear();
 	availableDaemons();
-	piForeachC(PIString & i, available_daemons)
+	for (const auto & i: available_daemons)
 		list_daemons->content << TileList::Row(i, CellFormat());
 	screen->unlock();
 	if (delim == 5 && mode == rmInformation) {
@@ -570,7 +570,7 @@ void Daemon::timerEvent(int delim) {
 PIStringList Daemon::availableDaemons() {
 	available_daemons.clear();
 	lock();
-	piForeachC(PIPeer::PeerInfo & p, allPeers()) {
+	for (const auto & p: allPeers()) {
 		if (!p.name.startsWith(pisd_prefix)) continue;
 		available_daemons << p.name.mid(6);
 	}

utils/system_daemon/file_manager.cpp

@@ -15,7 +15,7 @@ PIStringList FileManager::TileDir::selectedNames() const {
 	PIStringList ret;
 	PIMutexLocker ml(e_mutex);
 	PIVector<int> sind = selected.toVector();
-	piForeachC(int i, sind)
+	for (const auto i: sind)
 		ret << entries[i].name();
 	ret.removeOne("..");
 	return ret;
@@ -181,7 +181,7 @@ void FileManager::TileDir::buildNames() {
 	CharFlags cf = 0;
 	Color cc     = Default;
 	PIString fcol, scol;
-	piForeachC(PIFile::FileInfo & e, entries) {
+	for (const auto & e: entries) {
 		if (e.isDir()) {
 			t    = '/';
 			cf   = Bold;
@@ -258,7 +258,7 @@ FileManager::FileManager() {
 	labels->direction     = Horizontal;
 	PIVector<SSPair> ll;
 	ll << SSPair(" Esc", "Exit") << SSPair(" F5", "Copy") << SSPair(" F6", "Move") << SSPair(" F7", "MkDir") << SSPair(" F8", "Delete");
-	piForeachC(SSPair & l, ll) {
+	for (const auto & l: ll) {
 		tl = new TileSimple();
 		labels->addTile(tl);
 		tl->content << TileSimple::Row(l.first, CellFormat(White, Transparent, Bold));
@@ -315,7 +315,7 @@ PIStringList FileManager::selectedRemote() const {
 	PIStringList ret;
 	panels[1]->lock();
 	PIVector<int> sil = panels[1]->selected.toVector();
-	piForeachC(int i, sil)
+	for (const auto i: sil)
 		ret << panels[1]->entries[i].path;
 	panels[1]->unlock();
 	return ret;

utils/system_daemon/main.cpp

@@ -197,7 +197,7 @@ public:
 			// "]"
 			,
 			CellFormat());
-		piForeachC(PIPeer::PeerInfo & p, daemon_.allPeers())
+		for (const auto & p: daemon_.allPeers())
 			peers_tl->content << TileList::Row(p.name + " | d = " + PIString::fromNumber(p.dist) + " | p = " +
 			                                       PIString::fromNumber(p.ping()) + " | n = " + PIString::fromBool(p.isNeighbour()),
 			                                   CellFormat());
@@ -206,7 +206,7 @@ public:
 		peerinfo_tl->content << TileSimple::Row("Name: " + pi.name, CellFormat());
 		peerinfo_tl->content << TileSimple::Row("Addreses: " + PIString::fromNumber(pi.addresses.size()), CellFormat());
 		peerinfo_tl->content << TileSimple::Row("Neighbours: " + pi.neighbours.join(", "), CellFormat());
-		piForeachC(PIPeer::PeerInfo::PeerAddress & a, pi.addresses)
+		for (const auto & a: pi.addresses)
 			addrs_tl->content << TileList::Row(a.address.toString() + " | p = " + PIString::fromNumber(a.ping) +
 			                                       " | a = " + PIString::fromBool(a.isAvailable()),
 			                                   CellFormat());
@@ -217,7 +217,7 @@ public:
 				s += " -> " + pp->name;
 			peermap << s;
 		}
-		piForeachC(PIString & s, peermap)
+		for (const auto & s: peermap)
 			peermap_tl->content << TileList::Row(s, CellFormat());
 		updatePeerDiag(peerdiagdata_tl, daemon_.diagnosticData());
 		updatePeerDiag(peerdiagservice_tl, daemon_.diagnosticService());
@@ -238,9 +238,9 @@ public:
 		tile->content << TileList::Row("PID: " + PIString::fromNumber(sys_mon.statistic().ID), CellFormat());
 		tile->content << TileList::Row(line, CellFormat());
 		tile->content << TileList::Row("Threads:", CellFormat());
-		piForeachC(PISystemMonitor::ThreadStats & t, ts)
+		for (const auto & t: ts)
 			maxlen = piMaxi(maxlen, t.name.length());
-		piForeachC(PISystemMonitor::ThreadStats & t, ts) {
+		for (const auto & t: ts) {
 			line = PIString::fromNumber(++num).expandLeftTo(2, ' ') + ": ";
 			line += PIString(t.name).expandRightTo(maxlen, ' ') + ": k ";
 			PIString ns = PIString::fromNumber(t.cpu_load_kernel, 'f', 2);
@@ -256,7 +256,7 @@ public:
 		if (tinfo->visible) updateSysMon();
 	}
 	EVENT_HANDLER(void, menuRequest) {
-		piForeach(PIScreenTile * t, mtiles)
+		for (auto * t: mtiles)
 			t->hide();
 		daemon_.disconnect();
 		tmenu->show();
@@ -265,7 +265,7 @@ public:
 	EVENT_HANDLER2(void, tileEvent, PIScreenTile *, t, PIScreenTypes::TileEvent, e) {
 		if (t == tmenu) {
 			if (e.type == TileList::RowPressed) {
-				piForeach(PIScreenTile * t, mtiles)
+				for (auto * t: mtiles)
 					t->hide();
 				switch (e.data.toInt()) {
 				case 0: tinfo->show(); break;

utils/system_daemon/shared.cpp

@@ -130,7 +130,7 @@ void removeFiles(const PIDir & dir, PIStringList l) {
 	l.removeAll("..");
 	PIString ap = dir.absolutePath();
 	// piCout << "remove from" << ap;
-	piForeachC(PIString & s, l) {
+	for (const auto & s: l) {
 		PIFile::FileInfo fi = PIFile::fileInfo(ap + PIDir::separator + s);
 		if (fi.isDir()) {
 			PIVector<PIFile::FileInfo> el = PIDir::allEntries(fi.path);
@@ -149,7 +149,7 @@ bool cryptFiles(const PIDir & dir, PIStringList l, const PIByteArray & secret) {
 	if (secret.size() != PICrypt::sizeKey() || secret.isEmpty()) return false;
 	l.removeAll("..");
 	PIString ap = dir.absolutePath();
-	piForeachC(PIString & s, l) {
+	for (const auto & s: l) {
 		PIFile::FileInfo fi = PIFile::fileInfo(ap + PIDir::separator + s);
 		if (fi.isDir()) {
 			PIVector<PIFile::FileInfo> el = PIDir::allEntries(fi.path);