SHS/pip
4
3
Fork 0
Code Issues 16 Pull Requests 2 Actions Releases Wiki Activity

fix(PIThread): remove spurious unlock() in _waitForFinish

Browse Source 
The function called unlock() on thread_mutex without a matching
lock(), causing UB on Windows (releasing an unowned critical
section) or silently dropping a user-held lock.
This commit is contained in:
andrey
2026-08-06 17:01:30 +03:00
committed by andrey
parent 31ae52623d
commit 5e4a55cc0c
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/main/thread/pithread.cpp
-1
View File
@@ -1080,7 +1080,6 @@ bool PIThread::_waitForFinish(PISystemTime max_tm) {
if (!running_) return true; if (!running_) return true;
#ifdef WINDOWS #ifdef WINDOWS
if (!isExists(PRIVATE->thread)) { if (!isExists(PRIVATE->thread)) {
unlock();
return true; return true;
} }
#endif #endif