SHS/pip
4
3
Fork 0
Code Issues 16 Pull Requests 2 Actions Releases Wiki Activity

fix: Sender::tick accesses parent->diags_ without lock — data race / use-after-free

Browse Source
This commit is contained in:
andrey
2026-08-06 17:01:30 +03:00
committed by andrey
parent f5cf06c200
commit 288c1b3575
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/main/io_utils/piconnection.cpp
+8 -3
View File
@@ -1234,9 +1234,14 @@ void PIConnection::Sender::tick(int) {
if (data.isEmpty()) return; if (data.isEmpty()) return;
// piCoutObj << "write"<<data.size()<<"bytes to"<<devices.size()<<"devices"; // piCoutObj << "write"<<data.size()<<"bytes to"<<devices.size()<<"devices";
for (PIIODevice * d: devices) { for (PIIODevice * d: devices) {
int ret = d->write(data); int ret = d->write(data);
PIDiagnostics * diag = parent->diags_.value(d, nullptr); if (ret > 0) {
if (diag && ret > 0) diag->sended(ret); PIDiagnostics * diag = nullptr;
__device_pool__->lock();
diag = parent->diags_.value(d, nullptr);
__device_pool__->unlock();
if (diag) diag->sended(ret);
}
} }
} }