From 1c9cdbba19d0f7197a7bd555b9580e8efd12aed3 Mon Sep 17 00:00:00 2001 From: "andrey.bychkov" Date: Mon, 10 Aug 2026 15:48:12 +0300 Subject: [PATCH] fix(picloudserver): use piMin to avoid signed/unsigned UB in Client::readDevice piMini(max_size, buff.size()) implicitly narrows size_t to int, which is UB for large buffers. Replace with explicit piMin matching the correct pattern used in picloudclient.cpp. --- libs/cloud/picloudserver.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/cloud/picloudserver.cpp b/libs/cloud/picloudserver.cpp index 709f94ef..a6b3c94d 100644 --- a/libs/cloud/picloudserver.cpp +++ b/libs/cloud/picloudserver.cpp @@ -201,7 +201,7 @@ ssize_t PICloudServer::Client::readDevice(void * read_to, ssize_t max_size) { if (buff.isEmpty()) { sz = 0; } else { - sz = piMini(max_size, buff.size()); + sz = piMin(max_size, buff.size_s()); memcpy(read_to, buff.data(), sz); buff.remove(0, sz); }