SHS/pip
4
3
Fork 0
Code Issues 16 Pull Requests 2 Actions Releases Wiki Activity

fix(PISerial): break infinite loop when readDevice returns <= 0

Browse Source 
In the blocking read path (timeout_ms <= 0), the while loop had no
exit condition for readDevice() returning 0 (EOF) or -1 (error).
This caused an infinite busy-loop at 100% CPU. Added 'else break'
to exit the loop on read failure, matching the timeout branch
which already handles this case.
This commit is contained in:
andrey
2026-08-05 17:39:37 +03:00
parent b2e637ee2b
commit 13a9a75f79
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/main/io_devices/piserial.cpp
+4 -1
View File
@@ -513,7 +513,10 @@ bool PISerial::read(void * data, int size, double timeout_ms) {
all = readDevice(data, 1); all = readDevice(data, 1);
while (all < size) { while (all < size) {
ret = readDevice(&((uchar *)data)[all], size - all); ret = readDevice(&((uchar *)data)[all], size - all);
if (ret > 0) all += ret; if (ret > 0)
all += ret;
else
break;
} }
setOption(BlockingRead, br); setOption(BlockingRead, br);
received(data, all); received(data, all);